moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

Copy planning scene predicates in the copy constructor

Open galou opened this issue 1 year ago • 1 comments

Description

The child planning scene should behave as its parent, so the state- and motion- feasibility predicates should be copied as well.

The copy of the collision update callback is treated in a separate commit because I'm not quite sure how to do it properly. I guess that the cloned planning scene should not call the collision update callback to avoid confusion.

Often in the planning scene implementation, the child planning scene uses members of its parent when it doesn't have its own but this is not the case for the predicates so I did copy them.

Checklist

  • [x] Required by CI: Code is auto formatted using clang-format
  • [ ] Extend the tutorials / documentation reference
  • [ ] Document API changes relevant to the user in the MIGRATION.md notes
  • [ ] Create tests, which fail without this PR reference
  • [ ] Include a screenshot if changing a GUI
  • [ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

galou avatar May 29 '24 13:05 galou

@galou thank you! Can you update your branch to main? CI should succeed now.

henningkayser avatar Jun 14 '24 20:06 henningkayser