moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

Sync with MoveIt1

Open Abishalini opened this issue 2 years ago • 8 comments

This is a continued effort from https://github.com/ros-planning/moveit2/pull/2212. I am breaking down the original author's PR into multiple PR so it is easy to review.

Syncing the following commits

* [2022-09-09] [63660ef21] | Merge PR #3093: extended ACM editing in MSA {{Robert Haschke}} 
* [2022-08-30] [fd5b81c0e] | LinearModel: auto-stretch columns {{Robert Haschke}} 
* [2022-08-30] [90ba5d682] | Improve CollisionLinearModel::setData() {{Robert Haschke}} 
* [2022-08-30] [6b5f450f2] | Linear View: Consider state of "show enabled pairs" checkbox {{Robert Haschke}} 
* [2022-08-30] [0bee1abe4] | Simplify code {{Robert Haschke}} 
* [2022-08-30] [28bd73cca] | Allow disabling/enabling links by default {{Robert Haschke}} 
* [2022-08-29] [5c1531479] | Use matrix view by default {{Robert Haschke}} 
* [2022-08-29] [77c3d3692] | Reenable ACM editing {{Robert Haschke}} 
* [2022-03-15] [27c1d918c] | Display ACM considering default-disabled links {{Robert Haschke}} 
* [2022-03-15] [46e435244] | Drop unused Collision*Model::reason() {{Robert Haschke}} 
* [2022-08-30] [2f97f6e0d] | Fix stack use after scope {{Robert Haschke}} 

The commits are from PR - https://github.com/ros-planning/moveit/pull/3093

TODO

  • [ ] Test you can generate the following tags in SRDF using MSA
<disable_default_collisions link="link_name" />
<enable_collisions link1="link1_name" link2="link2_name" reason="optional-reason" />
<disable_collisions link1="link1_name" link2="link2_name" reason="optional-reason" />

Abishalini avatar Oct 31 '23 06:10 Abishalini

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (73f4551) 50.40% compared to head (a03375a) 50.71%. Report is 55 commits behind head on main.

Files Patch % Lines
...veit_setup_srdf_plugins/src/default_collisions.cpp 0.00% 65 Missing :warning:
...tup_srdf_plugins/src/default_collisions_widget.cpp 0.00% 42 Missing :warning:
..._setup_srdf_plugins/src/collision_matrix_model.cpp 0.00% 25 Missing :warning:
...e/moveit_setup_srdf_plugins/default_collisions.hpp 0.00% 10 Missing :warning:
..._setup_srdf_plugins/src/collision_linear_model.cpp 0.00% 6 Missing :warning:
...oveit_setup_srdf_plugins/src/group_meta_config.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   50.40%   50.71%   +0.31%     
==========================================
  Files         391      391              
  Lines       31982    32210     +228     
==========================================
+ Hits        16117    16331     +214     
- Misses      15865    15879      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 31 '23 07:10 codecov[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Jan 01 '24 12:01 github-actions[bot]

This pull request is in conflict. Could you fix it @Abishalini?

mergify[bot] avatar Nov 21 '24 12:11 mergify[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Jan 10 '25 12:01 github-actions[bot]

Codecov Report

:x: Patch coverage is 0% with 149 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 50.71%. Comparing base (73f4551) to head (a03375a). :warning: Report is 327 commits behind head on main.

Files with missing lines Patch % Lines
...veit_setup_srdf_plugins/src/default_collisions.cpp 0.00% 65 Missing :warning:
...tup_srdf_plugins/src/default_collisions_widget.cpp 0.00% 42 Missing :warning:
..._setup_srdf_plugins/src/collision_matrix_model.cpp 0.00% 25 Missing :warning:
...e/moveit_setup_srdf_plugins/default_collisions.hpp 0.00% 10 Missing :warning:
..._setup_srdf_plugins/src/collision_linear_model.cpp 0.00% 6 Missing :warning:
...oveit_setup_srdf_plugins/src/group_meta_config.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   50.40%   50.71%   +0.31%     
==========================================
  Files         391      391              
  Lines       31982    32210     +228     
==========================================
+ Hits        16117    16331     +214     
- Misses      15865    15879      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jan 10 '25 12:01 codecov-commenter

This pull request is in conflict. Could you fix it @Abishalini?

mergify[bot] avatar Jan 10 '25 12:01 mergify[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Mar 05 '25 12:03 github-actions[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar May 08 '25 12:05 github-actions[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Jul 02 '25 12:07 github-actions[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Aug 21 '25 12:08 github-actions[bot]