moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

Replace the nullpointer checking in the Planning Scene with std::optional

Open AndyZe opened this issue 1 year ago • 6 comments

Please ping @henningkayser or @tylerjw before starting this issue! It's just an idea.

Stuff like this:

std::unique_ptr<ObjectTypeMap> object_types_;

  if (!object_types_)
  {
    ObjectTypeMap kc;
    parent_->getKnownObjectTypes(kc);
    object_types_ = ObjectTypeMap(kc);
  }
  else
  {
    ...

Ought to be replaced with std::optional<ObjectTypeMap>.

#2132 is a good start at this that seems like it could be extended for:

scene_transforms_, robot_state_, acm_, object_types_

AndyZe avatar Apr 21 '23 21:04 AndyZe

Hi @AndyZe , @tylerjw and @henningkayser

I would like to work on this. Let me know what things I should be working on.

SuyashSapkal avatar Apr 22 '23 19:04 SuyashSapkal

I think we need to at least wait for a review of #2132 first. If it's acceptable, you could apply the same techniques again.

Thanks @SuyashSapkal

AndyZe avatar Apr 23 '23 01:04 AndyZe

I would like to work on this. Let me know what things I should be working on.

MEHARRAJ avatar Aug 29 '23 00:08 MEHARRAJ

@MEHARRAJ Thank you, feel free to open a PR with the necessary changes

sjahr avatar Sep 04 '23 07:09 sjahr

Hi @AndyZe @tylerjw , I would like to work on this issue . May I know what changes should I do ?

zearocode avatar Oct 17 '23 15:10 zearocode

Hey @AndyZe @tylerjw , has there been any progress on this ? If not, I would like to start work on this. Kindly lemme know.

utkarshanand140 avatar Feb 22 '24 20:02 utkarshanand140