moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

Plugin implementations should be moved out of moveit_core

Open tylerjw opened this issue 2 years ago • 6 comments

It would greatly simplify moveit_core if it was built as a single library instead of many small libraries linked together. One of the problems with this is that several plugins (not just plugin interfaces) are part of the moveit_core package. This got in the way of refactoring the build scripts for moveit_core into a single library, see #1801

Here is a directory for packages that contain moveit_plugins: https://github.com/ros-planning/moveit2/tree/main/moveit_plugins

Tasks:

  • [ ] Migrate collision_detection::CollisionDetectorBtPluginLoader from moveit_core into moveit_plugins.
  • [ ] Migrate collision_detection::CollisionDetectorFCLPluginLoader from moveit_core into moveit_plugins.
  • [ ] Migrate online_signal_smoothing::ButterworthFilterPlugin from moveit_core into moveit_plugins.
  • [ ] Update moveit_plugins package.xml to depend on these new plugins.
  • [ ] Search for any tests that previously depended on moveit_core for these plugins and update them to depend on their new packages.
  • [ ] Be happy!

I'd be happy to mentor doing this project.

tylerjw avatar Feb 03 '23 19:02 tylerjw

@tylerjw can i take this issue ?

sameergupta4873 avatar Feb 12 '23 19:02 sameergupta4873

Sorry, I think @ChrisThrasher is already working on it :/

AndyZe avatar Feb 12 '23 19:02 AndyZe

I am. It's turning out to be a really complicated problem given how parts of moveit_core depend on parts of these plugins.

ChrisThrasher avatar Feb 12 '23 19:02 ChrisThrasher

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

github-actions[bot] avatar Mar 30 '23 12:03 github-actions[bot]

I currently have no plans on coming back to this problem. My first attempt was fraught with issues due to moveit_core's complicated internal dependency graph. So long as major parts of moveit_core depend on aspects of these plugins then this refactor will be tricky.

ChrisThrasher avatar Mar 30 '23 21:03 ChrisThrasher

I'm becoming annoyed with this stale bot thing because these issues are less relevant to the project just because we don't have any new status on them.

tylerjw avatar Mar 30 '23 22:03 tylerjw