moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

[pilz_industrial_motion_planner] Add includes

Open galou opened this issue 3 years ago • 5 comments

Signed-off-by: Gaël Écorchard [email protected]

Description

Add missing #include.

Checklist

  • [x] Required by CI: Code is auto formatted using clang-format
  • [ ] Extend the tutorials / documentation reference
  • [x] Document API changes relevant to the user in the MIGRATION.md notes
  • [ ] Create tests, which fail without this PR reference
  • [ ] Include a screenshot if changing a GUI
  • [ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

galou avatar Mar 25 '22 10:03 galou

Codecov Report

Base: 50.97% // Head: 50.95% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (c18bc11) compared to base (b6fcac8). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   50.97%   50.95%   -0.01%     
==========================================
  Files         378      378              
  Lines       31658    31658              
==========================================
- Hits        16135    16129       -6     
- Misses      15523    15529       +6     
Impacted Files Coverage Δ
...al_motion_planner/pilz_industrial_motion_planner.h 100.00% <ø> (ø)
...ion_planner/src/pilz_industrial_motion_planner.cpp 100.00% <ø> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 65.97% <0.00%> (-1.45%) :arrow_down:
moveit_ros/moveit_servo/src/pose_tracking.cpp 76.78% <0.00%> (-0.47%) :arrow_down:
moveit_core/robot_state/src/robot_state.cpp 47.91% <0.00%> (+0.08%) :arrow_up:
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 79.93% <0.00%> (+1.14%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 25 '22 12:03 codecov[bot]

I just add all includes that I cite in the given file, i.e. possibly repeating an include in the source and associated header files. Just close the PR if you don't want this.

galou avatar Mar 30 '22 06:03 galou

@tylerjw what do you think?

henningkayser avatar Mar 31 '22 15:03 henningkayser

This pull request is in conflict. Could you fix it @galou?

mergify[bot] avatar Jun 15 '22 22:06 mergify[bot]

This pull request is in conflict. Could you fix it @galou?

mergify[bot] avatar Sep 27 '22 22:09 mergify[bot]

@ChrisThrasher what do you think of this PR? It doesn't seem to harm anything but also I'm not sure it is necessary. Should we decide on a policy of when you should include a header and where?

tylerjw avatar Nov 18 '22 02:11 tylerjw

Are these additional headers necessary to fix something?

ChrisThrasher avatar Nov 18 '22 03:11 ChrisThrasher

As stated, these includes are not strictly necessary.

galou avatar Nov 18 '22 08:11 galou

@galou thank you for the clarification. I'm going to close this for now. We should write a policy around what and when we include various things. There are many opinions about how we should use includes and we lack consistency.

tylerjw avatar Nov 18 '22 16:11 tylerjw