image_pipeline icon indicating copy to clipboard operation
image_pipeline copied to clipboard

ros2 version: image_rotate does not initialize the target and source _vectors in constructor

Open dcconner opened this issue 3 years ago • 2 comments
trafficstars

Need to add the following after onInit() call to update data; target_vector and source_vector default to zero

` target_vector_.vector.x = config_.target_x; target_vector_.vector.y = config_.target_y; target_vector_.vector.z = config_.target_z;

source_vector_.vector.x = config_.source_x; source_vector_.vector.y = config_.source_y; source_vector_.vector.z = config_.source_z;

`

dcconner avatar Apr 04 '22 00:04 dcconner

Can you please open a pull request with that change so we can review it? Thanks.

clalancette avatar Apr 26 '22 18:04 clalancette

I verified compilation for image_rotate, but I went in another direction and developed a new node for ROS 2 I called image_flip that I present in PR #743 for review . I'm not set up to fully test this PR

dcconner avatar May 01 '22 21:05 dcconner