navigation2 icon indicating copy to clipboard operation
navigation2 copied to clipboard

Adds missing commas so default plugin names are not stuck together

Open aaronchongth opened this issue 2 years ago • 4 comments

Signed-off-by: Aaron Chong [email protected]


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on Ubuntu
Robotic platform tested on gazebo simulation

Description of contribution in a few bullet points

Added missing commas to ensure default plugin lib names are accurate.

For Maintainers:

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

aaronchongth avatar Jul 26 '22 10:07 aaronchongth

@aaronchongth, please properly fill in PR template in the future. @stevemacenski, use this instead.

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

mergify[bot] avatar Jul 26 '22 10:07 mergify[bot]

@jwallace42 Thanks!

aaronchongth avatar Aug 01 '22 01:08 aaronchongth

Looks like you will need to get @SteveMacenski to approve but it LGTM. He gets back from vacation in a couple of weeks so we will have to wait :).

jwallace42 avatar Aug 01 '22 13:08 jwallace42

@AlexeyMerzlyakov are you able to approve pr's?

jwallace42 avatar Aug 01 '22 13:08 jwallace42

@AlexeyMerzlyakov should be able to approve / merge PRs like this

SteveMacenski avatar Aug 17 '22 22:08 SteveMacenski

@jwallace42, @SteveMacenski, my apologies. I was in PTO, and was not able to check this PR.

AlexeyMerzlyakov avatar Aug 18 '22 10:08 AlexeyMerzlyakov

No worries!

SteveMacenski avatar Aug 18 '22 16:08 SteveMacenski