ros_canopen
ros_canopen copied to clipboard
ros-industrial
Refine fatal error configuration.
This refines selection of fatal en non-fatal errors.
There was no way to select BUSOFF as non fatal. My use case would be to select BUSOFF as non fatal and configure the can device with a restart-ms.
There was no way to select BUSOFF as non fatal.
It was written this way on purpose ;)
My use case would be to select BUSOFF as non fatal and configure the can device with a restart-ms
Does this really work with this fix? (I did not have a chance to test it)
It was written this way on purpose ;)
Why would the BUS_OFF error be a special case? I think it's fair to treat it as the other errors. What will happen with BUS_OFF, is that the output queue will fill up, and eventually the send asio call will fail / block.
What will happen with BUS_OFF, is that the output queue will fill up, and eventually the send asio call will fail / block.
In our usecase, the output queue will fill up immediately and then the kernel driver would close the socket..
Why would the BUS_OFF error be a special case? I think it's fair to treat it as the other errors
Agreed. Again, I did not test this special case.