noether icon indicating copy to clipboard operation
noether copied to clipboard

Potential Divide by 0 in raster_tool_path_planner.cpp

Open mpowelson opened this issue 5 years ago • 1 comments

See comments on #31

mpowelson avatar Mar 21 '19 15:03 mpowelson

@drchrislewis After taking a look at this, I don't think this is actually an issue. There would only be a divide by 0 if one of the two largest axis of the OBB were length 0. That should only happen if the mesh is a line or a point. As far as I can tell, that particular piece of code should be fine with one of the dimensions = 0.

If you want, I can add an assert below each m making sure that they are >0. That would add a nice check if built in debug.

mpowelson avatar Jul 02 '19 15:07 mpowelson