noether icon indicating copy to clipboard operation
noether copied to clipboard

Improve Unit Tests

Open marip8 opened this issue 3 years ago • 0 comments

Problems

  • No real expectations on the results of the tool path planner in any test, just that a valid optional data type is returned
  • Surface walk planner does not produce expected results (see #34)
    • utest_1_surface_walk_bad
    • utest_2_surface_walk_bad
    • utest_4_surface_walk_bad
    • Non-deterministic results from surface walk planner(see #103, #47)
      • utest_13_surface_walk_bowl_bad_2
      • utest_13_surface_walk_bowl_bad_4
  • Eigen value edge path planner does not produce expected results
    • utest_10_eigen_value_edge_bad_2
    • utest_10_eigen_value_edge_bad
    • utest_16_eigen_value_edge_bad
  • Extra rasters feature also produces (one?) extra waypoints
    • utest_17_surface_walk_extra_rasters_bad

Solutions

  • [ ] Revise unit tests to use test fixtures to reduce code duplication
  • [ ] Add meaningful expectations to the results of the tool path generation (e.g. number of strokes, number of points per stroke, normal direction
  • [ ] Fix issues with surface walk and eigen value edge planners
  • [ ] Transform test meshes by non-identity transformation to ensure results are correct and not just coincidentally correct (see #136)

marip8 avatar Jun 22 '21 23:06 marip8