industrial_training
industrial_training copied to clipboard
Open Items
I will be using this issue to keep track of the open items provided by Jeremy and Austin as I fix them.
HIGHER-PRIORITY
Wiki
- [ ] Home - Session 4/5 reference "recap" slides at aeswiki/indigo-devel/ACD. Slides should be updated and relocated to main git repo.
- [ ] update instructions to match Descartes-related changes (see below)
- [x] remove disclaimer from exercise 4.0, Section 5.3 (Descartes-related changes)
- [x] finish testing/cleaning Section 4.3 exercises...
- [x] demo manip - should copy template_ws to home directory, not work within exercises directory
Git
- [x] slides – Verify that github contains latest slides (check file-mod timestamps on Git, R:/…pdf, R:/…pptx)
- [ ] Update prior exercises with Descartes-related changes:
- [ ] workcell.xacro flips camera by 180 (3.1416), not 90
- [ ] fake_ar_publisher should offset by (-0.5, 0, 0.5), not (0, 0, 0.5)
- [ ] myworkcell_node.cpp add ASyncSpinner, replace spin() with waitForShutdown()
- [ ] Should update fake_ar_publisher to flip orientation, so AR-tag Z points “Up” (or remove call to FlipTag in vision_node)
Austin
- [x] Copy the launch folder from:
industrial_training/exercises/Perception-Driven_Manipulation/solution_ws/src/collision_avoidance_pick_and_place/launch
to:
industrial_training/exercises/Perception-Driven_Manipulation/template_ws/src/collision_avoidance_pick_and_place/launch
- [x] There was a ur_driver driver.py node not found error that i haven't chased down, when using the template workspace
- [ ] Test Session 5 Training
- [ ] Check if wiki instructions build and work
- [x] 5.0
- [ ] 5.1
- [x] 5.2
- [ ] 5.3
- [ ] 5.4
- [ ] Check if example solutions build and work
- [x] 5.0
- [ ] 5.1
- [x] 5.2
- [ ] 5.3
- [ ] 5.4
- [ ] Check if wiki instructions build and work
Paul
- [x] Administer corrections to Power Point slides.
- [x] Submit PR with new slides.
@AustinDeric
Section 5.1 Testing:
Git
The git solution does not have any of the folders that were to be created per the instructions in the wiki.
Wiki
ASSERT(true) produced an error for me. Did you mean to have something else there? A quick glance through the googletest documentation shows that they have "ASSERT_TRUE(condition)" and "ASSERT_FALSE(condition" but nothing with just ASSERT(condition).
Section 5.3 Testing
Wiki
The instructions at the end suddenly use catkin_make while all the previous instructions all used catkin build. I was not able to get it to work. Any suggestions?
- Geoffrey
PR made for Exercise 4.3.
@Levi-Armstrong @AustinDeric The Wiki references recap slides that I do not have. Are those slides actually used in the lectures? if not, can we remove the link to those slides from the Wiki?.
@AustinDeric Ran through the Perception Driven demo setup in simulation and everything worked. We should probably wait until next time the classes come around to do robot testing again.