industrial_ci icon indicating copy to clipboard operation
industrial_ci copied to clipboard

[question] ccache in pre-release

Open tylerjw opened this issue 3 years ago • 7 comments

In our testing it seemed like pre-release wasn't using ccache but then I read the code for the pre-release test and I found these lines:

https://github.com/ros-industrial/industrial_ci/blob/e51bbf479becc97a9cadbff9d6d3b9f3374821f8/industrial_ci/src/tests/ros_prerelease.sh#L31-L33

These don't reference the CCACHE_DIR but instead check for the existance of a specific directory. Does this work if I have the ccache directory somewhere else?

tylerjw avatar May 02 '21 17:05 tylerjw

This was only a work-around for https://github.com/ros-infrastructure/ros_buildfarm/issues/695 and might not be needed anymore.

Does this work if I have the ccache directory somewhere else?

I am not sure if ros_buildfarm supports this (https://github.com/ros-infrastructure/ros_buildfarm/pull/582 wasn't merged yet).

mathias-luedtke avatar May 02 '21 22:05 mathias-luedtke

At the moment $WORKSPACE is a temporary directroy, but we could put it into $BASEDIR as well. Then you could cache it from there..

mathias-luedtke avatar May 02 '21 22:05 mathias-luedtke

Maybe WORKSPACE could be set to be BASEDIR if it was defined and then we could cache the ccache directory in there?

tylerjw avatar May 03 '21 22:05 tylerjw

Actually, CCACHE_DIR should work..

https://github.com/ros-industrial/industrial_ci/blob/bfc68c8a3d5adf12ea4074c2149582398b5b6b54/industrial_ci/src/tests/ros_prerelease.sh#L93-L96

mathias-luedtke avatar May 03 '21 23:05 mathias-luedtke

The ccache is forwarded properly, but it looks like ros_buildfarm does not use it anymore (https://github.com/ros-infrastructure/ros_buildfarm/pull/844).

mathias-luedtke avatar May 04 '21 17:05 mathias-luedtke

See https://github.com/ros-infrastructure/ros_buildfarm/pull/876 as well

mathias-luedtke avatar May 04 '21 19:05 mathias-luedtke

@tylerjw: please test #670. It should work with CCACHE_DIR. BASEDIR is now supported as well.

mathias-luedtke avatar May 06 '21 23:05 mathias-luedtke