industrial_calibration icon indicating copy to clipboard operation
industrial_calibration copied to clipboard

missing cost types

Open drchrislewis opened this issue 5 years ago • 0 comments

https://github.com/ros-industrial/industrial_calibration/blob/8f64e56ff1a399bae4bb1f4f8e0da889d6b024ea/industrial_extrinsic_cal/src/ceres_costs_utils.cpp#L27

@d-walsh pointed out that at least one cost type was removed in error. We need to verify that all cost types have been added to this helper function. I believe several cost have been added. Many costs implemented are unnecessary. We should clean it up to make it easier for people to know which cost to use when. For example, nobody I know of has used the library to calibrate the target itself. Therefore only the PK type (point locations known) are used.

drchrislewis avatar Apr 16 '19 06:04 drchrislewis