ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

[DiffDriveController] Add velocity limits for individual wheels

Open arslogavitabrevis opened this issue 3 years ago • 6 comments

Pull request for feature request #470

arslogavitabrevis avatar Nov 23 '22 21:11 arslogavitabrevis

Could you please add some testing too?

bmagyar avatar Nov 24 '22 07:11 bmagyar

I just had a look at the test that are already there.

I think I should bring the code added to the update function and the code that I will have add to the on_configure function for the test to be working well in a subclass like if was done for the speed_limiter to keep it clean. Do you think I should create a new class wheel_speed_limiter or should I enhance the actual speed_limiter class with the wheel limit feature?

arslogavitabrevis avatar Nov 28 '22 16:11 arslogavitabrevis

This pull request is in conflict. Could you fix it @arslogavitabrevis?

mergify[bot] avatar Dec 04 '22 09:12 mergify[bot]

Yes I think it would be interesting to use the JointLimitsParam. I will try use it.

Do you think I could pause this pull request in the meantime?

arslogavitabrevis avatar Dec 09 '22 15:12 arslogavitabrevis

This pull request is in conflict. Could you fix it @arslogavitabrevis?

mergify[bot] avatar Jan 08 '24 10:01 mergify[bot]

As we have now the possibility to parse the URDF directly, it make sense to use the velocity limits directly from the wheel joints. see #949 for an example.

christophfroehlich avatar Jan 08 '24 11:01 christophfroehlich