ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

Published 20 hours ago • verified publisher icon ros-controls

Parameter validation Result type change

Open tylerjw opened this issue 3 years ago • 3 comments

Here is a PR to update ros2_controllers for API change I have in this PR to generate_parameter_library: https://github.com/PickNikRobotics/generate_parameter_library/pull/81

tylerjw avatar Oct 02 '22 20:10 tylerjw

Please hold off on this. I have a second change that builds on this and I will prepare the second part and we can do it all at once.

tylerjw avatar Oct 05 '22 17:10 tylerjw

@tylerjw, just one idea. Can you maybe deprecate this change first? So you support both names (the old one with a deprecation warning) for a few months and then delete it? Then it would be much easier to make this switch.

destogl avatar Oct 08 '22 15:10 destogl

Yes, I can do that. I'll make the change that way first.

Sent from ProtonMail mobile

-------- Original Message -------- On Oct 8, 2022, 9:25 AM, Denis Štogl < @.***> wrote:

@.***tylerjw, just one idea. Can you maybe deprecate this change first? So you support both names (the old one with a deprecation warning) for a few months and then delete it? Then it would be much easier to make this switch.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.AATAAFI2TXGJWUAOI2IUMTDWCGG7NA5CNFSM6AAAAAAQ3BYSV6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSL2ZTLC.gifMessage ID: @.***>

tylerjw avatar Oct 08 '22 17:10 tylerjw

This pull request is in conflict. Could you fix it @tylerjw?

mergify[bot] avatar Dec 06 '22 19:12 mergify[bot]