ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

Add parameter to disable closed loop PID adapter manually

Open destogl opened this issue 3 years ago • 2 comments

Enable disabling closed-loop PID in JTC when velocity-only interfaces are used.

This is useful in cases where only velocity output should be used but closed-loop PID should not be used. For example when there are no state interfaces available or cotroller is used in a chain and state interfaces can not be directly used for calculation.

destogl avatar Aug 11 '22 17:08 destogl

Codecov Report

Merging #414 (16d8923) into master (e7f9962) will decrease coverage by 5.79%. The diff coverage is 20.43%.

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.43%> (-5.80%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.59%> (ø)
...ller/test/test_load_forward_command_controller.cpp
...ontrollers/src/joint_group_position_controller.cpp
...ectory_controller/test/test_trajectory_actions.cpp
... and 192 more

codecov-commenter avatar Aug 11 '22 17:08 codecov-commenter

This pull request is in conflict. Could you fix it @destogl?

mergify[bot] avatar Aug 21 '22 07:08 mergify[bot]