ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

Generate parameters for Joint State Broadcaster

Open tylerjw opened this issue 2 years ago • 2 comments

Signed-off-by: Tyler Weaver [email protected]

generate_parameter_library for joint_state_broadcaster

tylerjw avatar Jul 29 '22 20:07 tylerjw

Thanks this looks very good. Can we also add comments/documentation for each parameter?

Would you mind helping me do that? I have checked the box so you can push into any of these PRs.

tylerjw avatar Aug 03 '22 15:08 tylerjw

This pull request is in conflict. Could you fix it @tylerjw?

mergify[bot] avatar Aug 10 '22 16:08 mergify[bot]

Codecov Report

Merging #401 (44545cd) into master (e7f9962) will decrease coverage by 5.79%. The diff coverage is 20.65%.

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.65%> (-5.80%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.89%> (ø)
...ler/test/test_load_joint_trajectory_controller.cpp
...dcaster/test/test_load_joint_state_broadcaster.cpp
...test/test_load_joint_group_position_controller.cpp
... and 192 more

codecov-commenter avatar Sep 21 '22 18:09 codecov-commenter

This pull request is in conflict. Could you fix it @tylerjw?

mergify[bot] avatar Sep 28 '22 18:09 mergify[bot]