ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

Generate params for ForceTorqueSensorBroadcaster

Open tylerjw opened this issue 3 years ago • 2 comments

Signed-off-by: Tyler Weaver [email protected]

Another PR to adapt a controller to use GenerateParameterLibrary

tylerjw avatar Jul 27 '22 19:07 tylerjw

This pull request is in conflict. Could you fix it @tylerjw?

mergify[bot] avatar Aug 10 '22 16:08 mergify[bot]

Codecov Report

Merging #395 (d1ba918) into master (e7f9962) will decrease coverage by 5.79%. The diff coverage is 20.65%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.65%> (-5.80%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.89%> (ø)
...include/joint_trajectory_controller/trajectory.hpp
...lers/test/test_joint_group_position_controller.cpp
...nt_state_controller/src/joint_state_controller.cpp
... and 192 more

codecov-commenter avatar Aug 17 '22 16:08 codecov-commenter

I left some comments to help you fix some of the linter issues in case your local configuration doesn't match the expected format.

@erickisos thanks! But this was unfortunately not the issue with formatting. Now we should have everything correct.

destogl avatar Aug 22 '22 15:08 destogl

I am developing on ubuntu 22.04 with Humble and/or Rolling and I believe I have all the required linters correctly installed. Is there a guide somewhere?

It seems that CI is not catching changes to formatting and I have submitted several small PRs to fix formatting since I started working on this change.

tylerjw avatar Aug 22 '22 16:08 tylerjw