ros2_controllers
ros2_controllers copied to clipboard
Use methods in all controller in the same order (Let's make controller development a joy)
Hi,
Working on an extension of JTC (#140), it's very disturbing (or at least disconcerting) not having unified members/methods order between the different controllers and the controller_interface. The issue I have is jumping between different states of the controller and having to check all the time at which lifecycle state controller is, i.e., which members are filled and which not...
I propose to restructure controller_interface methods to the execution order and keep that throughout this repository.
P.S. I know this is a very unproductive request. Still, IMHO it's important to increase understanding and finally acceptance of the library...
Any thoughts?
I propose the following order:
- constructor()
- init()
- on_configure()
- command_interface_configuration()
- state_interface_configuration()
- on_activate()
- update()
- on_deactivate()
- on_cleanup()
- on_shutdown()