ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

[JTC] Renaming variables, reordering trajectory checks and fixing open-loop mode by adding last commanded time.

Open destogl opened this issue 1 year ago • 4 comments

This PR increseas readability of the JTC by renaming trajectory varialbes to be semantically correct and self explainable.

Also it reoders checks of the trajectories done in the callback. They are grouped based on the things they are checking, i.e., 1. data available, 2. time checks; 3. trajectory point checks.

Additionally, it adds "last_commanded_time_" for the open loop mode to be more correct when setting point before trajectory.

destogl avatar Feb 09 '24 13:02 destogl

This pull request is in conflict. Could you fix it @destogl?

mergify[bot] avatar Feb 10 '24 15:02 mergify[bot]

Recently merged the wraparound feature which caused some conflicts.

Also, this may be interesting for @fmauch

bmagyar avatar Feb 11 '24 16:02 bmagyar

:eyes: @destogl test_no_jump_when_state_tracking_error_not_updated fails now, I guess due to the last_commanded_time_ change.

christophfroehlich avatar Feb 12 '24 09:02 christophfroehlich

Please adjust / extend the tests

bmagyar avatar Feb 19 '24 18:02 bmagyar