ros2_control_demos icon indicating copy to clipboard operation
ros2_control_demos copied to clipboard

change hw_state_ to hw_position for only position command rrbot.

Open benthebear93 opened this issue 1 year ago • 2 comments

As a beginner, i been reading code for rrbot and diffbot together.

One thing that made me little confusing was variable's name.

variable for state of position only rrbot is

std::vector<double> hw_states_;

variable for diffbot is

  std::vector<double> hw_positions_;
  std::vector<double> hw_velocities_;

and rrbot_system_multi_interface has

  std::vector<double> hw_states_positions_;
  std::vector<double> hw_states_velocities_;
  std::vector<double> hw_states_accelerations_;

it's trivial but wouldn't it be better to unify the names of variables?

benthebear93 avatar Sep 17 '22 08:09 benthebear93

Such suggestions are best communicated through PRs ;)

bmagyar avatar Sep 17 '22 09:09 bmagyar

@bmagyar I will think about more general names to unify the variables names for command and state interface and do the PR.

benthebear93 avatar Sep 21 '22 12:09 benthebear93