ros2_control icon indicating copy to clipboard operation
ros2_control copied to clipboard

Confusing feedback when loading controller from CLI

Open bmagyar opened this issue 2 years ago • 0 comments

Describe the bug When loading a controller to a configured state, the CLI report Sucessfully loaded controller X into state active which isn't true. Either we need to revise the nomenclature of active/inactive or how we report things in list_controllers.

To Reproduce Steps to reproduce the behavior:

  1. Build ros2_control, ros2_controllers and ros2_control_demos from source.
  2. Start the rrbot demo ros2 launch ros2_control_demo_bringup rrbot.launch.py
  3. Load the JTC that is already in the rrbot config file: ros2 control load_controller position_trajectory_controller --set-state configured
  4. The CLI returns this print: Sucessfully loaded controller position_trajectory_controller into state active
  5. Nothing crazy happens though, only a misleading print. When running ros2 control list_controllers we get the correct output
$ ros2 control list_controllers 
joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active    
forward_position_controller[forward_command_controller/ForwardCommandController] active    
position_trajectory_controller[joint_trajectory_controller/JointTrajectoryController] inactive

Expected behavior This is what we should see when running the command

$ ros2 control load_controller position_trajectory_controller --set-state configured
Sucessfully loaded controller position_trajectory_controller into state configured

Environment (please complete the following information):

  • OS: Ubuntu 20.04
  • Version Rolling

bmagyar avatar Jul 26 '22 07:07 bmagyar