ros2_control icon indicating copy to clipboard operation
ros2_control copied to clipboard

fake_sensor_commands renamed

Open kvkpraneeth opened this issue 3 years ago • 2 comments

This PR resolves https://github.com/ros-controls/ros2_control/issues/774 issue to refactor all of fake_sensor_commands to mock_sensor_commands, Also adds a small deprecation warning if fake_sensor_commands is used.

kvkpraneeth avatar Jul 19 '22 16:07 kvkpraneeth

Codecov Report

Merging #782 (6416c48) into master (925f5f3) will decrease coverage by 1.99%. The diff coverage is 38.06%.

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   34.61%   32.62%   -2.00%     
==========================================
  Files          52       91      +39     
  Lines        2981     9268    +6287     
  Branches     1855     6229    +4374     
==========================================
+ Hits         1032     3024    +1992     
- Misses        310      720     +410     
- Partials     1639     5524    +3885     
Flag Coverage Δ
unittests 32.62% <38.06%> (-2.00%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 36.63% <ø> (-3.08%) :arrow_down:
controller_manager/src/realtime.cpp 0.00% <0.00%> (ø)
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 8.98% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) :arrow_up:
hardware_interface/test/test_component_parser.cpp 8.52% <ø> (-3.13%) :arrow_down:
... and 107 more

codecov-commenter avatar Jul 19 '22 16:07 codecov-commenter

@bmagyar if deprecation is in place we should merge this.

destogl avatar Jul 30 '22 13:07 destogl

This pull request is in conflict. Could you fix it @kvkpraneeth?

mergify[bot] avatar Sep 24 '22 07:09 mergify[bot]

@mergifyio backport humble

destogl avatar Oct 11 '22 07:10 destogl

backport humble

✅ Backports have been created

mergify[bot] avatar Oct 11 '22 07:10 mergify[bot]

@mergifyio backport humble

destogl avatar Oct 15 '22 18:10 destogl

backport humble

✅ Backports have been created

mergify[bot] avatar Oct 15 '22 18:10 mergify[bot]