ros2_control icon indicating copy to clipboard operation
ros2_control copied to clipboard

[Spawner] Accept parsing multiple `--param-file` arguments to spawner

Open saikishor opened this issue 1 year ago • 1 comments

When we use multiple controlers to activate or deactivate, it is quite cumbersome to accept only one --param-file arg as it is not very scalable. For this reason, now the spawner can accept multiple --param-file args and set the respective param_file to those corresponding controllers.

Along with the above mentioned change, now the controllers can accept multiple param-file args as well, and this is very helpful to be able to override parameters between parameter files as how it is done with the standard ROS 2 nodes

saikishor avatar Oct 19 '24 16:10 saikishor

Codecov Report

Attention: Patch coverage is 74.63768% with 35 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (23bd1c3) to head (5c79dd5). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...troller_manager/controller_manager/launch_utils.py 0.00% 19 Missing :warning:
.../controller_manager/controller_manager_services.py 80.00% 5 Missing and 5 partials :warning:
controller_manager/controller_manager/spawner.py 57.14% 1 Missing and 2 partials :warning:
controller_manager/src/controller_manager.cpp 70.00% 0 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   87.97%   87.91%   -0.07%     
==========================================
  Files         121      121              
  Lines       12403    12491      +88     
  Branches     1105     1121      +16     
==========================================
+ Hits        10912    10981      +69     
- Misses       1085     1103      +18     
- Partials      406      407       +1     
Flag Coverage Δ
unittests 87.91% <74.63%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/controller_manager/__init__.py 100.00% <ø> (ø)
controller_manager/test/test_spawner_unspawner.cpp 99.36% <100.00%> (+0.11%) :arrow_up:
controller_manager/controller_manager/spawner.py 72.65% <57.14%> (+0.43%) :arrow_up:
controller_manager/src/controller_manager.cpp 78.26% <70.00%> (+0.15%) :arrow_up:
.../controller_manager/controller_manager_services.py 79.08% <80.00%> (-0.02%) :arrow_down:
...troller_manager/controller_manager/launch_utils.py 0.00% <0.00%> (ø)

codecov[bot] avatar Oct 19 '24 16:10 codecov[bot]

Seems to be a good idea, and implementation LGTM.

Please update the doc section and release notes.

@christophfroehlich Done

saikishor avatar Oct 27 '24 18:10 saikishor

This pull request is in conflict. Could you fix it @saikishor?

mergify[bot] avatar Oct 30 '24 20:10 mergify[bot]

This pull request is in conflict. Could you fix it @saikishor?

mergify[bot] avatar Nov 06 '24 19:11 mergify[bot]

This pull request is in conflict. Could you fix it @saikishor?

mergify[bot] avatar Nov 18 '24 13:11 mergify[bot]