ros2_control icon indicating copy to clipboard operation
ros2_control copied to clipboard

Issue 759: This will add the cleanup service

Open bailaC opened this issue 1 year ago • 4 comments

https://github.com/ros-controls/ros2_control/issues/759

bailaC avatar Dec 18 '23 13:12 bailaC

@destogl Please check the draft PR. I think the main logic of the transition is missing. I will check again at my end.

bailaC avatar Dec 18 '23 13:12 bailaC

Codecov Report

Attention: Patch coverage is 33.33333% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 47.45%. Comparing base (ff3177b) to head (4d4ed45).

:exclamation: Current head 4d4ed45 differs from pull request most recent head 418e47a. Consider uploading reports for the commit 418e47a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1236       +/-   ##
===========================================
- Coverage   75.89%   47.45%   -28.45%     
===========================================
  Files          41       41               
  Lines        3352     3595      +243     
  Branches     1926     1962       +36     
===========================================
- Hits         2544     1706      -838     
- Misses        417      459       +42     
- Partials      391     1430     +1039     
Flag Coverage Δ
unittests 47.45% <33.33%> (-28.45%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../include/controller_manager/controller_manager.hpp 18.18% <ø> (-13.97%) :arrow_down:
controller_manager/src/controller_manager.cpp 38.91% <33.33%> (-30.46%) :arrow_down:

... and 30 files with indirect coverage changes

codecov[bot] avatar Dec 18 '23 13:12 codecov[bot]

This pull request is in conflict. Could you fix it @bailaC?

mergify[bot] avatar Feb 09 '24 10:02 mergify[bot]

This pull request is in conflict. Could you fix it @bailaC?

mergify[bot] avatar Apr 29 '24 12:04 mergify[bot]