ros2_control icon indicating copy to clipboard operation
ros2_control copied to clipboard

Added parameterized test for spawner.py

Open Nils-ChristianIseke opened this issue 1 year ago • 4 comments

Regarding #964. Replacement of pull request #1152.

This time I used parameterised tests. As always, welcome feedback. If this approach is approved, I will test all arguments of the spawner, this way.

Nils-ChristianIseke avatar Nov 09 '23 21:11 Nils-ChristianIseke

Thank you! Let's see the CIs opinion :)

bmagyar avatar Nov 09 '23 21:11 bmagyar

Codecov Report

Merging #1160 (85a2ba6) into master (b8ba5c0) will not change coverage. The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1160   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files          40       40           
  Lines        3445     3445           
  Branches     1866     1866           
=======================================
  Hits         1641     1641           
  Misses        480      480           
  Partials     1324     1324           
Flag Coverage Δ
unittests 47.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 09 '23 22:11 codecov[bot]

@bmagyar could you have a look:) CI was failing but should hopefully be fixed now.

Nils-ChristianIseke avatar Nov 18 '23 11:11 Nils-ChristianIseke

Pretty happy with how this looks. Time to add a few more instantiations to that parametrized test now! :D

bmagyar avatar Dec 12 '23 12:12 bmagyar