ros2_control
ros2_control copied to clipboard
Added parameterized test for spawner.py
Regarding #964. Replacement of pull request #1152.
This time I used parameterised tests. As always, welcome feedback. If this approach is approved, I will test all arguments of the spawner, this way.
Thank you! Let's see the CIs opinion :)
Codecov Report
Merging #1160 (85a2ba6) into master (b8ba5c0) will not change coverage. The diff coverage is
n/a
.
Additional details and impacted files
@@ Coverage Diff @@
## master #1160 +/- ##
=======================================
Coverage 47.63% 47.63%
=======================================
Files 40 40
Lines 3445 3445
Branches 1866 1866
=======================================
Hits 1641 1641
Misses 480 480
Partials 1324 1324
Flag | Coverage Δ | |
---|---|---|
unittests | 47.63% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@bmagyar could you have a look:) CI was failing but should hopefully be fixed now.
Pretty happy with how this looks. Time to add a few more instantiations to that parametrized test now! :D