gz_ros2_control
gz_ros2_control copied to clipboard
New branch and fix API breaking to allow Humble to work with Gazebo Garden
Hi guys, I created this PR to allow Humble to work with Gazebo Garden. I started to work with iron branch because it contains the porting from ignition to gazebo API. I discovered that the ros2_control repository has changed the API from Humble to Iron. Therefore, I updated the code with old version of ros2_control's API.
It seems to work without problem with Humble and Garden. My idea is to keep a two different branches, so a person can choose if need to work with Gazebo Garden or Ignition Fortress.
Tell me what do you think about this idea
sorry, I just noticed that I made a mistake on the branch. My idea is not merge this code in the branch iron but keep them in two difference branches. Tell me if it is possible
@federicociresola as we will not be able to relese this. It doesn't make much sense to merge this as you will anyway need to build everything from source, you can also work from your fork.
@destogl My idea is not merge it on main branch but create a separate branch (I don't know if it is possible because I am quite new in this world to contribute on public repository). I'm asking this because I am updating the code of create3 to work with Humble and Gazebo Garden (the idea is to make a PR for that project when I will finish) and it needs this patch. Therefore I thought that it was good for the community if they can use it from official repository also if they have to clone the repository and compile it