Rootul P

Results 489 comments of Rootul P

Providing the same DB to both CometBFT and celestia-app is causing a failure to fetch stores on `BeginBlock` for the first block. Used debugger to inspect the state of the...

At the time when v3 panics, v3 only has these keys: params, transient params, mem capability. The v2 state machine has `mountKeysAndInit` invoked on it. The v3 state machine never...

``` $ ./scripts/single-node.sh celestia-app home: /Users/rootulp/.celestia-app celestia-app version: 1.28.0-140-g28c8edde3 Do you want to delete existing /Users/rootulp/.celestia-app and start a new local testnet? [y/n] y Deleting /Users/rootulp/.celestia-app... Initializing validator and node...

Hitting an error I resolved earlier on this PR ``` $ ./build/node $ ./build/node 2024/10/21 15:50:57 proto: duplicate proto type registered: celestia.core.v1.da.DataAvailabilityHeader 2024/10/21 15:50:57 proto: duplicate proto type registered: celestia.core.v1.proof.ShareProof...

## Prerequisite - [x] Determine if multiplexer uses the local ABCI client or GRPC ABCI client. - [x] If uses local ABCI client then delete the GRPC ABCI client and...

> Some projects such as SEI have removed it Sei's ABCI local client doesn't appear to have CheckTx: https://github.com/sei-protocol/sei-tendermint/blob/81bf836ca6981f48d6811a724d91789d43cc8791/abci/client/local_client.go Sei's ABCI GRPC client doesn't have a mutex for CheckTx: https://github.com/sei-protocol/sei-tendermint/blob/81bf836ca6981f48d6811a724d91789d43cc8791/abci/server/grpc_server.go#L85-L91...

On a single-node devnet locally, only local client is used. Confirmed with ``` ./scripts/single-node.sh ./scripts/single-node-upgrades.sh ``` so it's true when running embedded apps and the native app. Also confirmed in...

Upstream still has the mutex for all methods: https://github.com/cometbft/cometbft/blob/main/abci/client/local_client.go

Updating the status from https://github.com/celestiaorg/celestia-core/pull/2345. Rachid verified that the proposed change does result in a benefit for CheckTx time. In order to proceed with that code change, we need a...

> For simple benchmarks where the entire loop body should be timed, the traditional for i := 0; i < b.N; i++ loop is still the correct and idiomatic approach....