Rootul P
Rootul P
Note a repo admin or maintainer w/ permissions needs to tackle this.
IMO `main` i no longer confusing b/c it's no longer the default branch. The default branch is now release/v0.46.x-celestia and soon it may be release/v0.50.x-celestia.
I think most of the default overrides have been moved to celestia-app's [default_overrides.go](https://github.com/celestiaorg/celestia-app/blob/fc03393dce943532c618da53069f9331fc575b1d/app/default_overrides.go). I think the remaining revertable overrides that can be moved to celestia-app are documented [here](https://github.com/celestiaorg/cosmos-sdk/blob/2a7b89a70adefaefb0d66f71c507304ee44e8344/README.md?plain=1#L26-L34).
@tzdybal is this issue still relevant? If yes, should it be moved to https://github.com/rollkit/cosmos-sdk?
Perhaps useful for assignee, you can generate code coverage via: ```shell cd service/header go test . --coverprofile=coverage.out go tool cover -html=coverage.out ``` service/header/store.go is at 79.9% test coverage. The uncovered...
@HoytRen it looks like it was moved to https://github.com/celestiaorg/celestia-node/tree/main/header For example: https://github.com/celestiaorg/celestia-node/blob/main/header/store/store.go
> Is there a way to only call this once in the multiplexer and then never call it in the application? No because the v2 state machine needs to work...
> if the multiplexer is the only thing that calls seal, and it gets ran no matter which state machine is picked, then is this true? We can do this...
The 10 second timeout looks already overwritten in celestia-app [here](https://github.com/celestiaorg/celestia-app/blob/952a455bd66c5c5674ab0a255f579ff48fa55652/app/default_overrides.go#L243-L245). Related: https://github.com/celestiaorg/celestia-app/issues/1034 In a node I have locally, the `~/.celestia-app/config/config.toml` contains: ```toml # How long to wait for a tx...
@joroshiba do you know which consensus full node you're connected to? It would be nice if we can verify what value they use for `timeout_broadcast_tx_commit`.