roottest icon indicating copy to clipboard operation
roottest copied to clipboard

[ntuple] add rntuple merge test skeleton

Open mxxo opened this issue 5 years ago • 7 comments
trafficstars

Add empty unit test intended to test RNTuple merges. We add a new macro execRNTupleMerge.C which will create RNTuples on the fly to be merged (following what happens for TTree, etc. in execFileMerger.C)

We can add future RNTuple merge tests using the files created as part of execRNTupleMerge (e.g. testing for hadd):

ROOTTEST_ADD_TEST(hadd-rntuple
                     COMMAND ${ROOT_hadd_CMD} -f merged.root ntuple1.root ntuple2.root
                     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
                     DEPENDS execRNTupleMerge)

mxxo avatar Jul 27 '20 22:07 mxxo

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 27 '20 22:07 phsft-bot

Closing in favour of a new RNTuple tutorial about merging as discussed with @jblomer.

mxxo avatar Jul 28 '20 15:07 mxxo

The tutorials and the test are not mutual exclusive. A tutorials should have code that looks the way user code should look like. While the test code be more pedantic about testing and checking. For example the test code might/should check that the resulting compression and size are as expected, the tutorials should not.

pcanal avatar Jul 28 '20 15:07 pcanal

That's a very good point, I am happy to include them both, especially since they will likely share a lot of code.

mxxo avatar Jul 28 '20 17:07 mxxo

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 28 '20 17:07 phsft-bot

Build failed on mac1014/python3. Running on macitois21.cern.ch:/build/jenkins/workspace/roottest-pullrequests-build See cdash. See console output.

Failing tests:

phsft-bot avatar Jul 28 '20 19:07 phsft-bot

@jblomer what are the plans with this PR?

Axel-Naumann avatar Mar 03 '21 14:03 Axel-Naumann