roottest icon indicating copy to clipboard operation
roottest copied to clipboard

Published 20 hours ago • verified publisher icon root-project

Re-enable fastcloningeventtree tests

Open vepadulano opened this issue 1 year ago • 38 comments

Fixes https://github.com/root-project/root/issues/14579

vepadulano avatar Feb 13 '24 16:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 13 '24 16:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 13 '24 18:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 13 '24 18:02 phsft-bot

I think we are almost there with this fix. It is just necessary to disable this test on Windows.

dpiparo avatar Feb 16 '24 12:02 dpiparo

@bellenot Is there an easy way to fix this test on Windows (seem a question of access a local Event.lib file, maybe it was not copied when the .dll was copied).?

pcanal avatar Feb 16 '24 20:02 pcanal

@bellenot Is there an easy way to fix this test on Windows (seem a question of access a local Event.lib file, maybe it was not copied when the .dll was copied).?

I already took a look and explained to Vincenzo. The Event.lib (and dll) are generated using a gnu makefile, hence not compatible with Windows. One should port that to CMake... I.e in root\tree\fastcloningeventtree\CMakeLists.txt there is set(ROOT_EVENT_DIR ${ROOTTEST_DIR}/root/treeformula/event/), and in ${ROOTTEST_DIR}/root/treeformula/event/ there is ROOTTEST_ADD_OLDTEST(), which is not compatible with Windows

bellenot avatar Feb 16 '24 20:02 bellenot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 19 '24 13:02 phsft-bot

It turns out these files were already ported to cmake previously, then the change was reverted https://github.com/root-project/roottest/pull/716

I re-reverted the change, make the needed adjustments afterwards using fixtures. On my machine everything works again now, let's see the Windows CI

vepadulano avatar Feb 19 '24 13:02 vepadulano

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

And 1 more

phsft-bot avatar Feb 19 '24 13:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 19 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

And 1 more

phsft-bot avatar Feb 19 '24 15:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 19 '24 17:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 19 '24 18:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 19 '24 19:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

And 1 more

phsft-bot avatar Feb 19 '24 21:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 19 '24 23:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/roottest-pullrequests-build See console output.

Warnings:

  • [2024-02-20T00:11:45.950Z] /Users/sftnight/build/workspace/roottest-pullrequests-build/roottest/root/treeformula/event/TreeFormulaEvent.cxx:146:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
  • [2024-02-20T00:11:45.950Z] /Users/sftnight/build/workspace/roottest-pullrequests-build/roottest/root/treeformula/event/TreeFormulaEvent.cxx:147:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

Failing tests:

phsft-bot avatar Feb 20 '24 01:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 20 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 20 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 20 '24 18:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 20 '24 19:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/roottest-pullrequests-build See console output.

Warnings:

  • [2024-02-20T19:27:02.773Z] /Users/sftnight/build/workspace/roottest-pullrequests-build/roottest/root/treeformula/event/TreeFormulaEvent.cxx:146:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
  • [2024-02-20T19:27:02.773Z] /Users/sftnight/build/workspace/roottest-pullrequests-build/roottest/root/treeformula/event/TreeFormulaEvent.cxx:147:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

phsft-bot avatar Feb 20 '24 20:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 21 '24 10:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 21 '24 10:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 21 '24 12:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 21 '24 13:02 phsft-bot

@pcanal this is now ready for review

vepadulano avatar Feb 21 '24 13:02 vepadulano

@phsft-bot build

vepadulano avatar Feb 23 '24 09:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 09:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 23 '24 09:02 phsft-bot