Christos Papageorgiou
Christos Papageorgiou
You are using wrong version of zabbixapi. For 5.0 and 5.2 zabbix version [this](https://rubygems.org/gems/zabbixapi/versions/5.0.0.pre.alpha1) is the correct version of the gem.
Please squash your commits before merging. Thanks!
@lduriez master branch of this module should be fixing this issue.
Hello @nambrosch and @jmcnatt! The patch seems okay but a unit test should be added before merging this. I think the unit test can be added in [jira_service_spec](https://github.com/voxpupuli/puppet-jira/blob/master/spec/classes/jira_service_spec.rb) file.
@nambrosch The unit tests for config files are mostly used to test something is render correctly to the file and it won't get broken in the future by some other...
Hello and thanks for brining this up! Are you able to provide a PR to fix this?
https://github.com/voxpupuli/puppet-mongodb/pull/633/files#diff-d6b333a9340fbaec381a43ac444b03b86d46883d35a6c4f4a8cc3a4b914d409dR89 Is the regex wrong or should we ignore rubocop here?
Ah, you're right!
That error was fixed at https://github.com/puppetlabs/rspec-puppet/pull/19 but it's back? :thinking:
As far as I see from the code you have to explicitly call zabbix::sender class with `zabbix_package_state` set. I don't think it's being inherited The default value is set in...