puppet-mongodb icon indicating copy to clipboard operation
puppet-mongodb copied to clipboard

modulesync 5.2.0

Open bastelfreak opened this issue 3 years ago • 5 comments

modulesync 5.1.0

bastelfreak avatar Dec 15 '21 19:12 bastelfreak

https://github.com/voxpupuli/puppet-mongodb/pull/633/files#diff-d6b333a9340fbaec381a43ac444b03b86d46883d35a6c4f4a8cc3a4b914d409dR89

Is the regex wrong or should we ignore rubocop here?

root-expert avatar Mar 12 '22 15:03 root-expert

I think it complains about when '0.0.0.0' and when %r{\[?::0\]?}, because they both do Facter.value(:fqdn)

ip_real = case first_ip_in_list
when '0.0.0.0', %r{\[?::0\]?}
Facter.value(:fqdn)

(or write it as a single regex)

bastelfreak avatar Mar 12 '22 16:03 bastelfreak

Ah, you're right!

root-expert avatar Mar 12 '22 16:03 root-expert

That error was fixed at https://github.com/puppetlabs/rspec-puppet/pull/19 but it's back? :thinking:

root-expert avatar Mar 12 '22 17:03 root-expert

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jun 21 '22 19:06 vox-pupuli-tasks[bot]