Ronen Amiel

Results 26 comments of Ronen Amiel

I'm honored and will be happy to join, thank you for inviting me :)

Adding some of my thoughts: I see `class-methods-use-this` as an opinionated rule that doesn't fit every project. Projects that enable the rule usually want to avoid non-static class methods that...

Since there's already a warning for this, I'm +1 on adding the option to exit with status code 1 instead. Warnings are often ignored, and being able to crash the...

> > Should this also warn on implicit returns for these predicates? > > My understanding of the question is - should we check function literals with implicit return type,...

> Oh, also noting that checking surrounding `never` doesn't seem to have been implemented. > > However, there is also already an issue, #2616, for including `never`-checking in _all_ our...

> Just posting a thought while https://github.com/typescript-eslint/typescript-eslint/pull/10051/files#r1828085145 is pending. Thanks @JoshuaKGoldberg; I'll update this section in a bit. To make sure, is https://github.com/typescript-eslint/typescript-eslint/pull/10051/files#r1828085145 pending for something from me?

> Last I checked it was requesting more test coverage. If that's done then we can re-review. 👍 The PR has gone through several changes since then (with the help...

> 👋 Hey @ronami, did you want to re-request review on this? > > No pressure, just asking because it's been a bit and I've seen other things from you...

> Hey @ronami, do you plan to make further changes regarding [#10310 (comment)](https://github.com/typescript-eslint/typescript-eslint/pull/10310#discussion_r1899103025) or is this intended to be reviewed as is? Oh, I'm sorry; I've looked into it but...