Rom Grk

Results 558 comments of Rom Grk

I'm exploring the disassembly of `xxh` on V8, it looks like it's doing a lot of validation and doesn't have confidence yet that it's indeed a Smi value despite all...

Note that you don't return anything from the goober hash functions in your tests, that might also impact the result (engines could ellicit an unused constant value with no side-effect)....

For the record, here is a confirmation that `'go' + number` (decimal formatting) is very efficient on v8. No significant difference in other engines: ![image](https://github.com/user-attachments/assets/ea8492a5-3c2c-4188-a6b4-d7ca8e539528)

I spent some more time refining the approach and optimizing the parsing/formatting functions. There was an issue with JS bitwise operators as they operate on 32-bits signed, and V8's Smi...

For the bundle size, it looks to be around 4KB. Feature-wise this PR is nearly complete so I'm not going to add any substantial amount of code, in fact I...

If the objective is compatibility with what `colorManipulator` currently supports (and not compatibility with the CSS spec), then this PR already does more than that and I can trim some...

I have finished the implementation, this is ready for review. There have been some changes to `colorManipulator`, I will comment below to explain why those changes happen. Overall this change...

I would have favored doing the switch at once now rather than keeping the two implementations. If we're going to change the color output/behavior, it feels safe/correct to do it...

I use this [TestCase](https://gist.github.com/romgrk/129623975dee66e90a9d2373a33eef7a) in a production build of react with 6x CPU slowdown to eliminate timer imprecision on short durations (sub-millisecond is imprecise, so I want test cases that...

The note above about `extractHex` is probably affecting performance (edit: if MUI uses hex a lot, not sure what's the most common format though), you should re-measure after fixing it.