Romén Rodríguez-Gil

icon indicating a website link https://www.romenrg.com icon indicating an email [email protected]

icon company @turo icon location Tenerife, Canary Islands, Spain icon location Lifelong Learner, Software Engineer and Digital Entrepreneur.

Results 4 comments of Romén Rodríguez-Gil

fix: Calculate check conclusion from annotations

P.S. Regarding: > Do we want "notice"-level annotations to result in a "neutral" conclusion or "success"? I currently have it count as "neutral" but could see wanting to reserve that...

Better error handling behavoir (--fail-on-error)

@asbjornu +1 to renaming `--level` to `--report-level`. I've run into the same confusion before. See my review to @carmanchris31 's PR: https://github.com/reviewdog/reviewdog/pull/1170#pullrequestreview-1079026347 where I describe the same confusion. Having at...

How do you get this to work?

After some attempts I got this to work today. Here are some things you might be missing: - in your `tsconfig.json`, make sure you have the `"include"` entry, which should...

fix: Calculate check conclusion from annotations

@haya14busa, any chance we can get this approved? It's a pretty relevant improvement, the PR is solid and it's been several months already. It is only pending a quick approval...