Robert Munteanu comments

Results 163 comments of


                                            Robert Munteanu

Possibility to report violations of the Content-Security-Policy

When reviewing please consider that csp/csp_report.php left as-is is at least a DOS vulnerability which allows an attacker to fill up a disk by just posting large JSON payloads.

Possibility to report violations of the Content-Security-Policy

@mfoXen - sorry, I didn't find the time to review this more in depth - maybe @dregad will be able to suggest a better way of securing the page. As...

Automated crash reporting in Mantis

I'll hold off the comments on the SOAP API changes and will wait for the other devs to comment on whether this is something that should go in. > Don't...

Fix false positive for FilterTest::testGetProjectClosedIssues

Overall LGTM, thanks @dregad for preparing the fix. My preference would be for keeping the current behaviour, see also my comment in [Bug #21996](https://www.mantisbt.org/bugs/view.php?id=21996), and if we decide to go...

Libcurl issue with openssl 1.1 [Tumbleweed][Arch]

For the record, this also affects Company of Heroes 2.

Libcurl issue with openssl 1.1 [Tumbleweed][Arch]

Confirming that for Company of Heroes 2 the fix works.

[native-image] Building a native image for the Apache Felix framework jar fails with multiple DeletedElementException instances

@cstancu - unimplemented methods are used at runtime, yes, as that's when OSGI frameworks do most of the class loading. I was wondering whether conceptually there is an option to...

[native-image] Building a native image for the Apache Felix framework jar fails with multiple DeletedElementException instances

@linghengqian - hm, not sure why that link broke, a working one is https://felix.apache.org/documentation/downloads.html#_felix_framework_distribution . That will point you to the latest version, the 6.0.3 version I referenced can be...

DockerComposeContainer doesn't report underlying issue on start failure.

For me, it would be useful to be able to diagnose exactly why compose was unable to start, e.g. - inspect container states to see which ones have failed -...

Include all support libraries in the Docker image

Thanks for considering this. In the meantime, we built our own simplistic image, but it would be good to not need it: ``` FROM bats/bats:latest as bats RUN apk add...