Romaric Pascal

Results 81 comments of Romaric Pascal
trafficstars

Quickly browsing through recent PRs (especially those of @querkmachine which are always pretty thorough and well written), here's a base structure for discussion: - **Logistics** (optional): warning if the PR...

This has also been flagged by @colinrotherham in this [comment](https://github.com/alphagov/govuk-frontend/pull/5787#issuecomment-2715163181). Wondering if: - for `ChildClass` we could have the one in `configuration.mjs` extend the one from `component.mjs` (as it's what...

[This comment](https://github.com/alphagov/govuk-frontend/pull/5787#issuecomment-2828080558) proposes a possible route.

Due to the amount of linking between pieces of documentation in the JavaScript API reference (eg. the type of a function param linking to another class in the docs), we'll...

Interestingly, Sass files are compiled twice: - once by [the `@metalsmith/sass` plugin](https://github.com/alphagov/govuk-design-system/blob/main/lib/metalsmith.js#L91-L105) (that's the obvious one you'd expect) - once when gathering [the colour palette injected as global metadata](https://github.com/alphagov/govuk-design-system/blob/main/lib/metalsmith.js#L79), [through...

In the meantime `npm start 2>/dev/null` gets rid of the warning noise

> I think we definitely want to make sure we're testing for read-onliness internally I know your comment now dates from a while back, but do you remember what you...

For the former, TypeScript is taking care of checking that 🥳 For the later, we could add some defensiveness (for example, wrapping the default config in a `Proxy` that throws...

Just noting in passing that there's some thorough guidance on [translating services to Welsh on the HM Land Registry Design System](https://hmlr-design-system.herokuapp.com/guidance/welsh-guidance/).

Little thought on this: if we need to avoid a breaking change but need to modify the markup to implement, the buttons start `hidden` and are revealed by JavaScript, so...