Romaric Pascal

Results 35 comments of Romaric Pascal

> Can we narrow down our Jest `projects: []` list (by directory/filename) in another PR? Yeah, that'd be fine by me so we get this one moving and tidy up...

Thanks for splitting the commits and going through all these changes. The move to async looks good to me, I like how it feels more parallel-y with the `Promise.all` 🙌🏻...

Making everything `componentData` makes more sense to me, as we keep the distinction from the component itself (in case we ever have tests that need to reference both).

Another thing that the change may break besides app using JS to check if the button is disabled may be the fixtures for validating non JS implementations. Rails outputs boolean...

Separating prototype kit specific code into its own folder sounds good to me, and I'd say that both config and JS and SCSS files should live there as well (option...

If that's helpful, here's a screenshot of a quick adjustment. That only postpones the wrapping to smaller viewport sizes (which happen pretty quickly) but I think we should at least...

@WebMechanic For the title, it'd sure be possible to pick the `aria-label`, `aria-labelledby`'s target `textContent` or even the first headings `textContent` to set the page title. Having an separate attribute...

As the component is relying on pluralisation, should it also receive a locale through data attributes to decide on which plural form to use? Was there any discussion around the...

[Ended up having a separate 'i18nLocale' option that falls back to 'lang' on the JavaScript side](https://github.com/alphagov/govuk-frontend/pull/2887#discussion_r983423951). Was there ever a discussion on passing the locale to the Nunjucks template or...

Good point of avoiding to encourage people of always setting a `lang` through a top level `lang` option in the macro options. That said, we're in a pinch with using...