Roman Zeyde

Results 503 comments of Roman Zeyde

Please squash and rebase over latest `master` (the last CI failure should be fixed by #480).

@gtbuchanan @SlugFiller could you please take a look? I don't use Windows, so I would appreciate your feedback :)

We have a PoC for signing Elements transactions (both explicit & confidential) at [elements/wip branch](https://github.com/trezor/trezor-firmware/compare/master...romanz:elements/wip), whose device tests work well on the emulator and the TREZOR model T device: ```bash...

Thanks :) Squashed and rebased over `master`.

Please let me know if I should "wrap" the Elements-related parts with `if not utils.BITCOIN_ONLY`.

Tested on bitcoin-only firmware with: ``` $ BITCOIN_ONLY=1 make -C core clean build_unix $ py.test tests/device_tests/ -k 'getaddress and not altcoin' ``` and on altcoin-enabled firmware: ``` $ BITCOIN_ONLY=0 make...

Rebased (to resolve a conflict) and force-pushed https://github.com/trezor/trezor-firmware/pull/474/commits/1e9563b18404994ef4d31ea93b21faab7d0a25e2. Please let me know if there is anything else that I can help with :)

> OTOH this seems to only affect GetAddress, in which case maybe that's not necessary? Indeed, currently it affects only GetAddress (for deriving the blinding public key). In future PR...

^ Rebased and force-pushed (to fix a merge conflict).