Roman Zeyde
Roman Zeyde
Fixed a few issues (following [SonarQube run](https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&sinceLeakPeriod=true&branch=32541-1f629743e6c6ba4fab77ef1a8578bb82f0a70566&id=aureleoules_bitcoin)).
I have used `ApacheBench 2.3` for benchmarking REST API, and [the following Rust client](https://gist.github.com/romanz/2630210f497b69d605cdb831fd057b98) for `getrawtransaction` RPC: # fetching using the new index ``` $ ab -k -c 1 -n...
Rebased to fix https://github.com/bitcoin/bitcoin/pull/32541#issuecomment-2971073957.
> As far as I understand the index makes this operation faster by not requiring to read the entire block and then iterating through the transactions to find the match...
Rebased over `master` to use `std::vector` (following https://github.com/bitcoin/bitcoin/pull/32743).
BTW, if I understand correctly, this index may also improve the performance of [`SendBlockTransactions` during handling of `GETBLOCKTXN` requests](https://github.com/romanz/bitcoin/blob/df45388b97ea4d808256302531d4443526edf794/src/net_processing.cpp#L4181).
Rebased over `master` and fixed `rest_tx_from_block()` argument name case (in addition to https://github.com/bitcoin/bitcoin/pull/32825).
Rebased over `master` after https://github.com/bitcoin/bitcoin/pull/32825 is merged (to resolve a small conflict).
Added a short description in `doc/REST-interface.md` and `doc/files.md`, and updated release notes in https://github.com/bitcoin/bitcoin/pull/32541/commits/c695d134683d52bce9e499a5848e4c4c7951155c. Please let me know if there are any additional open issues :)