Roman Štrobl
Roman Štrobl
The key encapsulation example in the documentation mentions that Bob's public key is transported to Alice. The example is missing public key serialization and deserialization on Alice's side.
The round 3 implementation of SIKE introduced changes in following constants for various SIKE parameters: - `SIDH_SECRETKEYBYTES` - `NBITS_ORDER` - `MAXBITS_ORDER` We should double check whether these changes have any...
The round 3 SIKE implementation introduces subtraction with reduction using 2p and 4p. This change should have a minor impact on performance.
As part of effort to eliminate potential side channel attacks, branching should be removed in SIKE decapsulation to prevent advanced timing attacks.
The `MontgomeryCurve` class contains fields `a` and `b`. The `a` constant used in reference implementation is different from the `A` constant used in optimized implementation. Furthermore, the `b` constant is...
Some of the methods in `Fp2Element` class differ from the official implementation (e.g. `sqrt`). Although these methods are well tested, we should compare the performance and security parameters with the...
The mobile SDK configuration serialization/deserialization code is duplicate in `powerauth-server` and `powerauth-cmd-tool` projects. It should be moved to the `powerauth-crypto` library.
Let's fix these warnings: ``` DocuCheck: WARNING: documentation/Activation-Recovery.md:114: Link [Key Exchange](Activation.md#key-exchange) points to an unknown header in the document. DocuCheck: WARNING: documentation/Activation.md:39: Link [Activation via Custom Credentials](#activation-via-custom-credentials) points to an...
Performance of delete methods generated by Spring Data JPA is not optimal and can be improved by using JPQL directly. Following methods can be optimized: - `PushCampaignUserRepository::deleteByCampaignId` - `PushCampaignUserRepository::deleteByCampaignIdAndUserId` -...
The following issue occurs whenever activation record is updated, the application record is updated as well: ``` 2023-06-01T15:22:38.335+02:00 DEBUG 2696217 --- [io-8080-exec-39] org.hibernate.SQL : update pa_application set name=?, roles=? where...