Roman Ivanov

@rnveach , please finish review. If something is left please copy question/concernt one more time to this PR.

I can not find any reason to have extra characters in IF expression: ``` if (m instanceof Map) { // expected violation } if (m instanceof Map _) { //...

InputImportOrder_Wildcard >// groups are configured as follows // com.puppycrawl,*,java // the trailing javax.crypto.Cipher; should be flagged as a violation. such comments should be just removed.

``` ✔ ~/java/github/romani/checkstyle [SteLeo1602/FixViolations L|✚ 5⚑ 2] $ git diff diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/writetag/InputWriteTag.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/writetag/InputWriteTag.java index 3a82af6..88aa7be 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/writetag/InputWriteTag.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/writetag/InputWriteTag.java @@ -2,15 +2,15 @@ WriteTag tag = @author tagFormat...

``` ✔ ~/java/github/romani/checkstyle [SteLeo1602/FixViolations L|✚ 4⚑ 2] 22:32 $ git diff diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic2.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic2.java index dd18428..80afa66 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic2.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic2.java @@ -10,7 +10,6 @@ ignoreComments = (default)false */...

We can avoid updates in multiline comments, I did it below only because I investigated a root reason of problem. You can skip such updates. ``` ✔ ~/java/github/romani/checkstyle [SteLeo1602/FixViolations L|✚...

to fix problems in Filters ``` ✔ ~/java/github/romani/checkstyle [SteLeo1602/FixViolations L|✚ 1⚑ 2] 23:01 $ git diff diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java index dd3b1e7..3249bf9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java @@ -709,14 +709,14...

We can , but such comments are from time when we don't have BDD and had to jump between input file and Java test to see where is violation and...

@SteLeo1602, please fix CI failures

Github, generate website