Roman Ivanov
Roman Ivanov
@rnveach, please consider this PR to be merged before better fix is provided. Better to have 100% migrated modules to easily see all changes in result xml files on each...
we do not store user provided value as-is, https://github.com/checkstyle/checkstyle/blob/8531fec143058ddd92fab14839f2e9389ac6cf5c/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java#L264C19-L264C48 final type is List, so it is conceptually null-able. User can not set `null` even to java bean, it will be...
@rnveach, @nrmacuso, please consider this update. it is not conflicting with update in Check that we will do, but it will make special list for "null"s for properties, I will...
We can merge this and deal with null in separate PRs. If we can not find easy way to change Checks, hack will stay for longer, but main point that...
https://github.com/checkstyle/checkstyle/issues/14216 is approved and will be fixed separately. This update is just to finish macros udpates and start dealing with https://github.com/checkstyle/checkstyle/issues/14234 . We can do it righaway, if you approve...
@nrmancuso , I am assigning this PR to you to confirm that it is not blocking/conflicting with your PR of type change. and it will be easier for you to...
rebased to resolve conflict.
@rnveach , what comment define you request for change? I see label but not sure what you do not like. I hope current update is small step forward with gating...
Yes, Main point is to migrate to macros. And deal with Checks unfortunate design later on .
@rnveach , only macros usage in this PR now.