Roman Ivanov
Roman Ivanov
We lost contact to author, sad, but we still can merge this PR.
@rnveach , mutation is good catch. getNextPoint is just give next position in line. findChar does iteration over line string by such points and comparison of charater in this position...
Extra pitest survival is required to be removed https://github.com/checkstyle/checkstyle/actions/runs/7745731528/job/21122392399?pr=14404#step:7:23 Please share your analysis on why this code is not required. It might not required for existing Checks but might be...
@MANISH-K-07, please restore some comments and change them to be not `ok` pitest failure is hard block on PR
I don't see explanation why null is not possible. I see it possible at this place https://github.com/checkstyle/checkstyle/blob/73571a13c77c116253afac18b1cf9f59eafcac87/src/main/java/com/puppycrawl/tools/checkstyle/utils/CheckUtil.java#L383 Please share wide details why it would never come to that place?
I will put annotation on method:)
>Nothing has been said why this has to be a custom override I thought https://github.com/checkstyle/checkstyle/issues/14178 explains all. >and we don't accept the default of the system we have set up,...
>why do we have that if we don't want it showing up? Our logic is correct: get default value field. But we have nuance, there is no field here, default...
> or this check doesn't follow 99% of our other rules Check is not following our naive/simple rules. It is first time we run into such implementation. Separate issue will...
I am going to finish migration this week, and start fixing issues that we postponed until end of macros migration to eliminate unfortunate cases in SiteUtils.java