Results 1611 comments of Roman Ivanov

we found this https://github.com/checkstyle/checkstyle/pull/16489#discussion_r2097764721 as good rule on when space is very good - parameters indentation is same as first statement indentation. ``` private static DetailAST findRedundantNullCheck(DetailAST logicalAndNode, DetailAST instanceOfNode)...

@MateuszStefek, please report issue by our template, it will show all details that you missed, and we will avoid a lot of conversations.

please share link to snyk report please share output of dependency-check-maven

Moved to https://github.com/checkstyle/checkstyle/pull/15405

this will help https://github.com/checkstyle/checkstyle/issues/12542 when we get a fix

workaround is at https://github.com/checkstyle/checkstyle/issues/12542#issuecomment-1366687081 attention to location of Filter, it should be before TreeWalker. If you have not way to define exact file to use by Sonar plugin, not a...

Semaphore failure is expected due to new check. javac21 must be fixed.

@kkoutsilis , please run diff testing.

https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#executing-generation-using-github-action Attention to `New module config: {{URI to new_module_config.xml}}` And attention to other merged PRs description, there are bunch of examples

Looks like false positive https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/43f253c_2025211859/reports/diff/camunda/index.html#A1 Please review your report your self first, to shorten feedback loop. Looks like I was to quick to respond to this PR :)