Roman Ivanov
Roman Ivanov
GitHub, generate website
Please reply "done" as confirmation that get best practice of PR review
@Lmh-java , please help us to finish this PR, we are so close to merge state. looks like only version should be changed.
Sure, one day we will do summary. But if we pause, we will never find next problems for us. Our problem is that part of our code is API. But...
@rnveach , please share your opinion.
>create an issue to discuss not using bitset. It is ok to use it, such a performance optimization is far future, and I am not sure about it. For now...
@rnveach , here is a discussion https://github.com/checkstyle/checkstyle/pull/14673#discussion_r1539414373 here is my answer - https://github.com/checkstyle/checkstyle/pull/14673#discussion_r1545892195
@rnveach , I replied you on May12 https://github.com/checkstyle/checkstyle/pull/14673#discussion_r1597848629 , please consider this PR one more time.
New Check needs to be created. https://checkstyle.org/writingchecks.html If you would like to design it, here is guide on how to do this https://checkstyle.org/report_issue.html#How_to_request_new_Check.2FModule.3F This will be very controversial, without any...
nice! we encourage people to create their own public collections of Checks, not need to push all to standard set of Checks. People should use few jars in their build...