Roman Gershman

Results 808 comments of Roman Gershman

Our architecture is entirely different that of Redis, so we can not support Redis Modules. Supporting Redis Bloom filter is currently a low priority and not scheduled for 2023.

The Bloom filter library is pretty big. Do you have specific APIs/commands in mind?

bf.* are supported in v1.16.0. persistence support is coming for the next version

@e271828- we currently do not have plans to implement the countring filter. We may consider contributions from the community.

btw, we support hyper log log api.

I know Professor Roy Fridman and I agree it's super interesting to implement those data structures. I guess we will have to wait for someone who is willing to use...

1. `JournalReader::ReadString` is inefficient - and does double memory copy and possibly enlarges io_buf due to ``` if (auto ec = EnsureRead(size); ec) return make_unexpected(ec); ``` instead of reading what's...

More comments: Do not define classes bundled with long implementations together (`ClusterShardMigration`). It's not very readable.

we do that in full sync and it works super fast so I believe it's not the reason. one of the things I would check is around thread locality of...

Ok, we do not have on replica for full sync as well, so maybe it's not that.