Roman Gershman

Results 808 comments of Roman Gershman

we need to be able to merge statistics (since each thread manages its own). https://github.com/cafaro/UDDSketch talks about mergeability as its differrentiating property. I am still curious how it is done...

we need histogram per command and each histogram contain multiple buckets. so it will be wasteful to also use thread-local data-structures for that. Long story short, I will use [HdrHistogram_c](https://github.com/HdrHistogram/HdrHistogram_c)...

To clarify - in addition to the info section like this: ``` # Latencystats latency_percentiles_usec_ping:p50=2.007,p99=2.007,p99.9=2.007 latency_percentiles_usec_set:p50=13.055,p99=13.055,p99.9=13.055 .... ``` there is also a `latency histogram [cmd]` command (currently not implemented) but...

@Pothulapati can I merge it?

We had a bug in DNS code. it was fixed

I reproduced it locally with master in debug or opt mode. easily reproduces. ```sh mkdir /tmp/logmaster /tmp/logslave ``` ## Master config: ``` # Dragonfly Configuration File --port=6380 --maxmemory=10G # Enable...

True. In that case I would like the team to take over this PR and add the metric. Also maybe fix https://github.com/dragonflydb/dragonfly/issues/3210 while we are at it.

AFAIK, Redis Enterprise does not allow forwarding commands for any key. You did not explain why multiple hosts is the requirement for your use-case.