Roman Gershman comments

Results 808 comments of


                                            Roman Gershman

merge MapperExecutor::GetStats and metric_map_ logic

Pipeline should allow saving all the metrics exposed in metric map via SaveMetricMap() method after the pipeline run.

implement cache testing tool

another thing, it could be nice if it could also send synthetic traffic, without any files, probably using `incrby` command that will allow sending write-only traffic and still measure the...

Lets start with the following tasks 1. Implement a tool in python that sends a traffic distributed using [zipfian distribution](https://en.wikipedia.org/w/index.php?title=Zipf%27s_law). I am not an expert in statistics, but I know...

maxmemory should support human-readable format like MB or GB

we can use `ParseHumanReadableBytes` function from common.h. One thing to note - absl flags support customer flags parsing. see here for example: https://github.com/abseil/abseil-cpp/blob/master/absl/flags/parse_test.cc#L201

implement creation of deb package via cmake

thanks Acheev, much appreciated. and it's not urgent at all.

implement creation of deb package via cmake

hi @acheevbhagat, are you planning on working on this?

implement creation of deb package via cmake

Well, now you are officially assigned 😆 I will keep reminding you from time to time ;)

implement creation of deb package via cmake

Thanks, Acheev. I actually do not know myself how to generate the deb package, so at this point you already know better than me. I trust you do the necessary...

implement creation of deb package via cmake

I do not know enough to say why either option is better. Currently, I just do not have time to learn the domain, waiting for the team to grow and...

replace dict with string_set

the initial plan is as follows: - [ ] to write an md file explaining string set - [ ] to pull out `sds` related code out of StringSet and...